CR6Community / Marlin

This Marlin fork has the goal of cleaning-up the source code changes for the CR-6 so it can be merged upstream. We also want to extend the functionality to make it fully functional
GNU General Public License v3.0
470 stars 83 forks source link

Please display the Z-offset on the printing screen #114

Closed ztakis closed 3 years ago

ztakis commented 3 years ago

Description

Print Screen does not display Z-offset

Expected behavior:

All other info is shown, why not Z-offset?

Sebazzz commented 3 years ago

This is by design. In our opinion the Z offset is not necessary compared to the other data points. You set and forget, or tune it from the tuning screen.

ztakis commented 3 years ago

I believe it is helpful as a reminder, especially if someone is using various nozzles from different manufacturers. And more than once I have change it in real time when I noticed that the first layer didn't came out as expected.

Sebazzz commented 3 years ago

Changing it in real time would still happen in the tuning screen.

Assigning this to @grobux to see if we still have some space somewhere for this.

ztakis commented 3 years ago

May I suggest something like this:

printing

dryphi commented 3 years ago

I believe it is helpful as a reminder, especially if someone is using various nozzles from different manufacturers. And more than once I have change it in real time when I noticed that the first layer didn't came out as expected.

How do you change the Z-height in real time?

ztakis commented 3 years ago

By using the Tune screen.

Thinkersbluff commented 3 years ago

Since we can now tap to change many of the parameters displayed in the footer of the Printing Screen, the only two parameters we need the Tune screen for are LED ON/OFF and Z Offset... I could live with shorter pushbuttons if it created the missing real-estate for those controls on the Printing screen.

ztakis commented 3 years ago

That's a great idea! Why not abolish the Tune button all together, then make the Pause and Stop buttons horizontal, one next to the other like the CONFIRM/CANCEL buttons. Then there should be enough space for LED ON/OFF and Z Offset.

Thinkersbluff commented 3 years ago

To play “Devil’s Advocate”, though, the current ability “to tap to modify” those parameters is not self-evident, while the “Tune” button is... Users familiar with stock and previous menus would start posting a lot of questions if the Tune button suddenly disappeared.

Sebazzz commented 3 years ago

I agree. The tap to modify function is just a little extra for the ones who know how to find it. And the tuning screen is still there for firmware retraction, LED control etc.

Thinkersbluff commented 3 years ago

This seems like a relevant test-case for structuring decisions about the future menu tree, under issue #121

As someone who does know that tap to modify is there, I sometimes find myself wishing that either the M117 messaging was also on the Tune menu (because then I could just sit on the Tune menu & monitor my print) or that the Z Offset was also available to tap to modify on the Print screen (to try to improve a first layer in real-time.)

You @Sebazzz have the "unfair advantage" of having already started experimenting with live firmware retraction settings, which we have not. I am sure the optimal menu structure should be workflow-oriented, to create screens optimized for what I will want to do while I am doing that workflow. Question will be whether all possible scenarios of the entire printing workflow can be supported on a single screen (highly unlikely if you keep enriching the UI) and if not, which sets of functions should be grouped together for best effect?

ztakis commented 3 years ago

In order to close this, I submit these variations of the printing screen which I think have the potential to satisfy most users and seem not too difficult to implement:

printing1

printing2

printing3

Sebazzz commented 3 years ago

Good input, thank you.

I like the second the most, but I do worry about the ability of DWIN to render the X/Y/Z values that small and readable. Needs some experimentation I guess. For the status I'd abbreviate Linear Advance Factory to simply LA.

More personal opinion: I don't like the LED button in the middle of the other values; I also doubt the value of needing to have that LED so accessible. Regardless, it looks out of place to me 🙂

ztakis commented 3 years ago

For Linear Advance Factor you might use K-factor also but LA is fine too. As for the LED, you might want to replace it with the retraction override button or indicator (not touchable) Personally I use the LED often to check the printing progress and how clean the nozzle is. That's an older variation:

printing4

rockymtngeek commented 3 years ago

@ztakis I like that location of the LED button as well as the rest in your last screenshot.

Sebazzz commented 3 years ago

For Linear Advance Factor you might use K-factor also but LA is fine too.

I thought of that, but the K-factor is an even more obscure term. K refers to the K in the linear advance formula.

For the retract override we currently have these icons:

4_Retract_override_OFF 3_Retract_override_ON

Sebazzz commented 3 years ago

BTW: I would opt for a combination of the older design and the second design: X/Y/Z at the bottom, LED in the top bar, and a retract override indicator at the status part.

ztakis commented 3 years ago

I agree for that combination. For retract override you have these toggles too

9_FWRetract_on 10_FWRetract_off

We can make something squarish out of that

Sebazzz commented 3 years ago

Yes, perhaps for the status part just retain the icon without the label.

ztakis commented 3 years ago

printing5

Sebazzz commented 3 years ago

Yes, exactly like that 😄

ztakis commented 3 years ago

Glad you like it :)

Sebazzz commented 3 years ago

So, going forward:

I'Il assume you don't want to get into that DWIN rabbit hole, and also assume you mocked that up in Photoshop/GIMP 😉

Would it be possible to update the appropriate PSD here with the screen (without the M117 and X/Y/Z placeholders). and create a "print paused" and "print finished" variant of this as well? For import in DWIN BMPs need to be exported from the PSD as well. (FYI @grobux )

Thanks again.

ztakis commented 3 years ago

Believe it or not I made all this with Paint 3D. But yeah I'll give it a try with gimp.

ztakis commented 3 years ago

@Sebazzz Shouldn't we close this?

Sebazzz commented 3 years ago

You're right. don't know how this slipped through the net 😄