search

CRAG666 / code_runner.nvim

Neovim plugin.The best code runner you could have, it is like the one in vscode but with super powers, it manages projects like in intellij but without being slow
MIT License
539 stars 38 forks source link

nice plugin :-) #19

Open michaelb opened 2 years ago

michaelb commented 2 years ago

Hi, i'm here kinda on technological watch as sniprun's developper and I found you through the similar interactions an user (z0xyz) had on both our repos. Since you had that mention on your readme about not having found suitable projects then, I wondered if that was just a matter of timing (sniprun wasn't half as good/popular in feb 2021) or if it didn't make the cut for some other reason.

Also, looks like we both were jealous of VSCode's code runner and decided to create our own plugin ahah ! Your approach is very similar to the original thing though ! We don't do exactly the same thing, but feel free to steal features take inspiration from sniprun and I won't hesitate to do the same.

Code-writingly yours, Michael

CRAG666 commented 2 years ago

@michaelb I'll take your word for it. This plugin doesn't go the way of yours, it goes by the KISS principle, I want to keep it as simple as possible without adding too many configuration options or complexity in the code. But I have one word for your plugin "It's absolutely amazing" and yes I discovered it not long ago and believe me it blew my mind, I currently use my own plugin and the reason is just that I integrate it with harpoon. On the other hand I would like you to try this plugin and I will try yours and we can give each other feedback.

By the way, I started this idea in August 2020 but in another repository which is not as successful as this one. I completely wrote all the logic in python, then I created a new repository with a catchier name, initially I created the plugin in python and lua, then I realized that "pure lua" was popular and decided to write everything in that language and this is the result. What you see is the result of this work and who knows maybe in the future someone will complain about the performance of lua and write it in C. I leave the repository below if you want to take a look at it and maybe you want to be a contributor of that command line tool:

https://github.com/CRAG666/crlvc

michaelb commented 2 years ago

I would like you to try this plugin

I'll give it a shot one of those days

michaelb commented 2 years ago

So far, not so good...

I haven't been able to make this work in under 15min, which is a lot, by my standards; my main pain points are:

CRAG666 commented 2 years ago

@michaelb python -U is deprecated in python 3 use python -u instead

CRAG666 commented 2 years ago

The reason for not having default values ​​is so as not to saturate the load of the plugin (which in itself does not consume much) to only have what you actually use. something more handmade

CRAG666 commented 2 years ago

As for the version, if it supports version 6, in fact there is already a branch for version 7, it is an error in the README that I will solve right now.

michaelb commented 2 years ago

it is an error in the README that I will solve right now.

you can probably expect people to use python3, and update your example with "python -u" . Also some typos (ExapleDeno/ExapleCpp) and general phrasing, and the quick start guide doesn't work:

if I require('code_runner').setup({}) in my neovim configuration, I get:

E5108: Error executing lua ...acker/start/code_runner.nvim/lua/code_runner/options.lua:18: attempt to index field 'term'
 (a nil value)                                                                                                          
stack traceback:                                                                                                        
        ...acker/start/code_runner.nvim/lua/code_runner/options.lua:18: in function 'set'                               
        ...e/pack/packer/start/code_runner.nvim/lua/code_runner.lua:7: in function 'setup'                              
        [string ":lua"]:1: in main chunk

which is quite problematic, given your readme is quite long and it takes times for newcomers to grasp where is what information.

The reason for not having default values ​​is so as not to saturate the load of the plugin (which in itself does not consume much) to only have what you actually use. something more handmade

Imo, this argument is not valid; having 5-10 more lines of Lua won't ever, ever make a >0.1ms difference on your startup time, and while you should let users customize their build&run one-liners to suit their non-standard files/projects/stuff, most of the time there is one sensible way to do thing, that the users shouldn't have to be bothered with.

I've noticed some minor bugs, such as the terminal including line numbers (which is not super useful and takes up precious space), and the focus being switched to the output split (in the terminal), which may be intended, but is (at least for me) more a pain than a gain

CRAG666 commented 2 years ago

@michaelb check the new version

krishnakumarg1984 commented 2 years ago

@michaelb The new version of code_runner is pretty awesome. Congratulations @CRAG666 for the updates that made it highly usable.

Also, it would be nice if both the authors can check-out iron.nvim. It would be nice to have a three-way comparison so that the community can make an informed decision about which one to adopt for their individual workflows.

Look at this example of how two related neovim plugin authors came together to discuss and provide comparison/benchmarks. While one plugin inspired the second, the unique features of the second are now starting to be back-ported with a different algorithmic approach. In short, everyone benefits and it is a stimulating experience.

The community is richer thanks to you, the developers!

michaelb commented 2 years ago

I'm back :-)

code_runner is indeed way more polished than it was a few months ago, and for me it reached the point of "it just work, it's neat". The last two (minor) friction points for me are:

Great job!

@krishnakumarg1984 comparing the three is a good idea I think, I'm still short on time though...

CRAG666 commented 1 year ago

@krishnakumarg1984 Could you help us with the task of comparing the three plugins?