search

CRAVA / crava

6 stars 13 forks source link

CRA-861: Fixed issue with reading xyz-surfaces in the case when area … #256

Closed hgolsen closed 7 years ago

hgolsen commented 7 years ago

…is taken from surface.

alfbr commented 7 years ago

Is this related to #254 or #255 ?

hgolsen commented 7 years ago

This is related to both. This is a general fix for reading xyz-surfaces, but tested on a simpler case. It is not certain that it fixes both these problems, so please re-run both cases when this pull-request is merged.

alfbr commented 7 years ago

Great, already downloaded and compiled. Will try to get it tested over here.

alfbr commented 7 years ago

PR tested. The inversion still fails, at the exact same location. This is the error message:

cravarun: ../libs/nrlib/surface/../grid/grid2d.hpp:147: size_t NRLib::Grid2D::GetIndex(size_t, sizet) const [with A = double]: Assertion `j < nj' failed.

hgolsen commented 7 years ago

Sorry. This was not merged (this was only a request for merging), so you did not have the updates. (There is usually a small delay from when a request is made to when it is merged into the master branch.)

I have merged the commit into the master branch now. Can you test again tomorrow?

alfbr commented 7 years ago

I am not completely ignorant ;-) I forked your repository, and double checked that this commit was in there before I compiled:

$ git log commit 403f6c5901416fa7026e44913e0e68ade8e648f2 Author: Håvard Goodwin Olsen Havard.Olsen@nr.no Date: Tue Feb 28 13:06:24 2017 +0100

CRA-861: Fixed issue with reading xyz-surfaces in the case when area is taken from surface.
hgolsen commented 7 years ago

Ah, okey :) I didn't think of that option. Then these issues are still unresolved.

alfbr commented 7 years ago

Yes, I believe so. You have the datasets, so please see if you can reproduce at your end.