CRBT-Team / Purplet

A framework for quickly building Discord bots + more packages relating to the Discord API, with a primary goal on a rich developer experience.
https://purplet.js.org
Apache License 2.0
64 stars 1 forks source link

Purplet depends on `@discordjs/rest`'s `cdn` object which we didn't implement #51

Closed paperdave closed 2 years ago

paperdave commented 2 years ago

We didn't implement this feature because it's not rest related, it's just url generating. We can create some utilities at some point. Will probably be closed during dev of purplet structures

Hycord commented 2 years ago

Feels like something that should be put into buncord

paperdave commented 2 years ago

@Clembs this would likely go into @purplet/structures directly when needed, or maybe do you think having a separate set of url formatter functions like getEmojiURL(emojiId, imageOpts) in a package like @purplet/utils (a package i've already wanted to make for some discord-specific utility functions we have).

all i know is the rest client seems like the wrong place for this logic since it's not the usual thing to be fetching these resources, and even if that was the case, they are not json results (obviously) and other implications.

Clembs commented 2 years ago

I'm 100% on board with coding a @purplet/utils package, which I also thought of a while back.

Clembs commented 2 years ago

closed with commit ce4f3fe