Pair programming code review

[omar25ahmed]

Hello Chris: Your code is perfect, Good points to highlight:

• The code is well organized and looks good
• you have implemented the remove method nicely

Points to improve:

• [ ] It would be better if you add the local storage set item inside of a function and keep calling it instead of using it many times
• [ ] also when you edit the task the submit by Enter key is now working because you have written it e.key === 13 and this is outdated now but you can use e.key === 'Enter'

[mengiefen]

Hi @CRClothier ,

Congratulations! Your work is neat. 💯 💥

There are some suggestions if you add them it might be useful for work:

• The description-input element is always in enabled mode. The content may change without the intention of the user. What do you think if you make them disabled and when the user clicks edit button they enabled to update the todo description.
• Part of the todo description does not display if it has larger number of characters. If you use text wrapping option, this problem can be solved.
• When the text size of the description exceeds the set charter size, the delete buttons will be push out of the box.