CRED-CLUB / neopop-web

NeoPOP components library based on CRED's design system
https://playground.cred.club
Apache License 2.0
958 stars 146 forks source link

Link Button has no semantics that actually make it a "Link" #48

Open ccsCoder opened 1 year ago

ccsCoder commented 1 year ago

Describe the bug Button kind = link has zero semantics. In fact it is rendered with <div class="styles__TypographyWrapper-sc-1n7hass-0 cICjag font sans-serif" font-size="11" font-weight="500" color="#0d0d0d">Link</div>, which does not describe itself as a true "Link".

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Button Demo'
  2. Inspect Link and try checking its accessibility properties.
  3. Note that it is rendered using a div and not as an Anchor.

Expected behavior I would expect Links to render with Anchor tags with a proper Href etc.

Screenshots DOMSHOT

<div class="styles__TypographyWrapper-sc-1n7hass-0 cICjag font sans-serif" font-size="11" font-weight="500" color="#0d0d0d">Link</div>

Desktop (please complete the following information):

Kota-Karthik commented 1 year ago

@bigint @ccsCoder @harish-sethuraman I am interested in doing this issue So kindly assign me this Thank you :)

bigint commented 1 year ago

cc @harish-sethuraman

Kiranravi10X commented 4 months ago

Button Render Like this Right?

image