search

CREDITSCOM / node

Credits Node is the main module that provide an opportunity to run a node and participate in CREDITS blockchain network.
https://developers.credits.com/
GNU Affero General Public License v3.0
150 stars 16 forks source link

API:transactionsGet total_trxns_count always returns 0 #12

Closed tkoen93 closed 5 years ago

tkoen93 commented 5 years ago

Describe the bug The transactionsGet API function always returns that the result is false. The total_trxns_count is set to 0, but I do get my requested transactions as well.

Found in the code that total_trxns_count is returned when MONITOR_NODE is defined, which probably isn't the case for the nodes provided.

Code -> https://github.com/CREDITSCOM/node/blob/master/api/src/apihandler.cpp line 471/473

Probably not really a bug, as it should work for the MONITOR_NODE. I think this should work on any node.

The second screenshot shows that the response from my own took over 10 minutes. That is somehow very, very slow compared to the WEB_WALLET_NODE.

Screenshots image

image

ghost commented 5 years ago

Thanks for your feedback. This works only for the MONITOR_NODE. In the future, either there will be a fully customizable assembly node during assembly, or we will add this functionality to the base node.