search

CREDITSCOM / node

Credits Node is the main module that provide an opportunity to run a node and participate in CREDITS blockchain network.
https://developers.credits.com/
GNU Affero General Public License v3.0
151 stars 16 forks source link

Contract using payable function causes negative balances #20

Open tkoen93 opened 5 years ago

tkoen93 commented 5 years ago

Describe the bug Upon starting my node (testnet v4.2.416) my logfile shows the following: [2019-06-07 11:30:48.491091] [0x00007f37bb4057c0] [debug] Wallet with negative balance (-0.0077168) detected: 6100C7689D0446141532FF4FB1E0E8165ADCF1A104FDD1189E37459671584EE5 (7XfEfVkMxj78Y5N9PDHtkzcUuUWbnhJEyFrWH2U59N2Q) [2019-06-07 11:30:48.491117] [0x00007f37bb4057c0] [debug] Wallet with negative balance (-0.00257227) detected: 1F468EE473980EA87FA7E9BEB0D638475E8CB866DB6A7C3A153746C6E7BEF8E3 (3763MhjaHYvNXSR84CwcEBmD3dGyLSmbZqnrkaesV322) [2019-06-07 11:30:48.491129] [0x00007f37bb4057c0] [debug] Wallet with negative balance (-0.0102891) detected: 596C739032AB0D4AA0F2472C7B449521E015FBD357407D24168A0874A3F6D8BB (725Cc665HDxXdELakREL3efdpaNMdfXevkX27NgkUw3g)

Public keys: 7XfEfVkMxj78Y5N9PDHtkzcUuUWbnhJEyFrWH2U59N2Q 3763MhjaHYvNXSR84CwcEBmD3dGyLSmbZqnrkaesV322 725Cc665HDxXdELakREL3efdpaNMdfXevkX27NgkUw3g are all smart contracts using public void payable.

According to the monitor the balance of those keys are 0, but my node shows otherwise (balance requested via WalletBalanceGet api function).

7XfEfVkMxj78Y5N9PDHtkzcUuUWbnhJEyFrWH2U59N2Q image

3763MhjaHYvNXSR84CwcEBmD3dGyLSmbZqnrkaesV322 image

725Cc665HDxXdELakREL3efdpaNMdfXevkX27NgkUw3g image

Some other strange behaviour regarding this is that the monitor shows 0.0 balance, and the web wallet node responds through the API with balance 0.0.

I tried two user nodes, and those nodes both return a negative value. Meaning that there is a difference in balances between nodes in this testnet.

ghost commented 5 years ago

is the node in sync?

tkoen93 commented 5 years ago

That shouldn't matter, as negative balances should never ever occur. Synced or not. Did a quick restart of my node to check the log_0.txt

[2019-06-13 16:33:06.071929] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.0077168) detected: 6100C7689D0446141532FF4FB1E0E8165ADCF1A104FDD1189E37459671584EE5 (7XfEfVkMxj78Y5N9PDHtkzcUuUWbnhJEyFrWH2U59N2Q)
[2019-06-13 16:33:06.071976] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.00257227) detected: 1F468EE473980EA87FA7E9BEB0D638475E8CB866DB6A7C3A153746C6E7BEF8E3 (3763MhjaHYvNXSR84CwcEBmD3dGyLSmbZqnrkaesV322)
[2019-06-13 16:33:06.071993] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.0102891) detected: 596C739032AB0D4AA0F2472C7B449521E015FBD357407D24168A0874A3F6D8BB (725Cc665HDxXdELakREL3efdpaNMdfXevkX27NgkUw3g)
[2019-06-13 16:33:06.072012] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.0308672) detected: 0E114FC4B805809E86325B68085ED1DBE8150589729737AF14F30D4052503C1D (wv24LAr1GZbZwNRyXtzoET84yRiedMFZi2xCpw4fjzk)
[2019-06-13 16:33:06.072028] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.0077168) detected: D5A1F644D8B9994BA70004A4A8D5A16C293B8A1161C0DE30E8F882AF393F40E4 (FNw5cs4mMN2xX7q1ktHQg7vSCgyyR3ev8aEkxEkU8Pns)
[2019-06-13 16:33:06.072043] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.00900293) detected: FEF0EA1E499A8472CA0BAB202E86515A3EF1858B763BD8982B189CBEB32DBA55 (JABd2uwT5VKc8TwR2X2d8gwwS1d8EV9wSiUVP43Fs83v)
[2019-06-13 16:33:06.072059] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.00857422) detected: 5D07CF8B25C611B80604E99FC13FAF8C66ED0803DF77E8E33228F430B3E00EB9 (7G9pn2WPwKVoP8mKAQAVhUjambKif5Kibtgv2JZpURsW)
[2019-06-13 16:33:06.072073] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.0171484) detected: EA152381D9302ED0DD9AC0C285C08E8BC89AE64121A1A9E35DA15F5078862850 (Gkm6bTUzTdGWU3KDJDVSyzLKJqEDxvu53w8RahiKUQtF)
[2019-06-13 16:33:06.072088] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.132043) detected: 50B25F1F909C390BECAA6B58B4BA75FDBB9EEFD79FFEB553C7046534C89A6EC2 (6S1NNnpyMJpKWmMCKhapJ7xy5Coh56NiGsa9BA7oeHXF)
[2019-06-13 16:33:06.072102] [0x00007f78821997c0] [debug] Wallet with negative balance (-2.4304) detected: 90299F2DD4AED3FAB364418D1D1838C1742401B6EF277AA601582DF1E93AF0C1 (AhkX6vbhBjRdK8sfyRRUKN1CDyR7eFnkNQh2ePbVpB12)
[2019-06-13 16:33:06.072120] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.10975) detected: 7404572229B15CE057702BFA7D13D75321208C4AE226E2E7BB4F71A4CCF05445 (8ot8de4VEvd1wLBEoF1peb3BskFZPnt3VyGMUxTjFTwJ)
[2019-06-13 16:33:06.072135] [0x00007f78821997c0] [debug] Wallet with negative balance (-3.50543) detected: A54355F22C094A6F0A9DD2C80E6B35AB3D43FD6E023094628B5BE22CE7F55D97 (C87pgqqanL8s5K9gy9zFSC8FTs4FFGwmgh1PNaRoxw4S)
[2019-06-13 16:33:06.072152] [0x00007f78821997c0] [debug] Wallet with negative balance (-8.73937) detected: 2357D961B4982E61B7BC0E6E5ABDD20ACE9F17161215DA868D249312DAFC6189 (3NxxtjCs2nbzaLGHskQ4QgNbEQ3n8KEgBGpoX4ieBr2k)
[2019-06-13 16:33:06.072175] [0x00007f78821997c0] [debug] Wallet with negative balance (-1.64625) detected: 476BC9A91E307C55F1B0BAF698E98F750922DD16C6ED392DED48714B7CE3A24B (5ooGvdKPuTeQZPZJFjVQpD7v9cBtuG6qE2PvW86ij33G)
[2019-06-13 16:33:06.072192] [0x00007f78821997c0] [debug] Wallet with negative balance (-1.23469) detected: C5C93A3EE4B3000748926EA57A352006F4527042F6699E98BE2B8487E27FD045 (EK5HRM9NMXhz7queZfwwvZnx7XYFNGPhmE8MoF8BLu7a)
[2019-06-13 16:33:06.072206] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.725863) detected: D85E7B035651B8A7C521670FA9846AE55A0EEF5226E20BE403052CDA9356B531 (FZcd4dCbVS75zmZiNJEwQ32Byzh52nxX7QT8Ek4996xg)
[2019-06-13 16:33:06.072227] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.0460938) detected: A9319F9FD8DA28CD9DDC18729BE6AC49F895E1409EF2FA7E9E17CE4DD7C9E454 (CPTnibHJYTBtdBMnHyQ3Mvh6AA9H2r5eLvQwhQTJKy7y)
[2019-06-13 16:33:06.072242] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.0823125) detected: 29F581774E114B78D1C2C473DFDA8F26348A4970188C4835BC7A4C767C7DDC07 (3pnqqtDw2R8hMCGMTje855PFgKbgwB15AyPK3LP91HHg)
[2019-06-13 16:33:06.072257] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.205781) detected: 2AF69EEEED852CD661D65E861A1F87459744896855F01ED8DFFF4897E68D2A82 (3tiEgyYyfMCV2EUzSgLbSuZkUrLPECnh69uFLFSazwi9)
[2019-06-13 16:33:06.072272] [0x00007f78821997c0] [debug] Wallet with negative balance (-1.73199) detected: EB336E87ECFD1FB34F192BF4CAC6CD0CA0A0C1357E89BDACFB3BDED2114B9430 (Gq8J91agdkpoemDB5mQiRtKc456rgZZbgVAb3uTf5i1m)
[2019-06-13 16:33:06.072306] [0x00007f78821997c0] [debug] Wallet with negative balance (-7.41916) detected: FD519F77865623075EFCB2DF97B0EA7A362784DD374CF8D6A731BF7E3194B08A (J3rLSoQJdkwauQkNgvH8HGcK3eys7CbjzrLjQv63LhqK)
[2019-06-13 16:33:06.072323] [0x00007f78821997c0] [debug] Wallet with negative balance (-1.69427) detected: AD82D09C81DBA53422AB63277DEF137C88FBBAD276BE0283651369E51F835225 (CgKE47UKK3yrqF5ihJW6qVq31o3sREndGS4fLNpMiGKn)
[2019-06-13 16:33:06.072338] [0x00007f78821997c0] [debug] Wallet with negative balance (-0.617344) detected: E544ED108239CBA265927645396156CA6C6D05971912F7C86D490A8E3023857F (GRyKdvUgX6yJo4qHLABfBdK17MqXgAnkR2Zx1PCEahxJ)
ghost commented 5 years ago

Thank you for your log. We are aware of this problem and are actively working on fixing it.

tkoen93 commented 5 years ago

For your information, issue still exists on latest testnet release.

[2019-06-19 19:52:27.499479] [0x00007f8fdd88b7c0] [debug] Wallet with negative balance (-0.0102891) detected: 4F2743065237D912ECCBEB618A707A40BC262AE1ECAE9FCD2B6EDF038C5CFC56 (6Kyw2UGvpraJ1VnBxazujG5a3qLdqWjUq4QEVh4Kas65)
[2019-06-19 19:52:27.499526] [0x00007f8fdd88b7c0] [debug] Wallet with negative balance (-0.000857422) detected: 8016EABB79AF5FC1E159C9DC45BC11694D4E5D272E0C6D1D0E26A5897E1D0AF4 (9d1THRG6kYhJPdy4NyJsC3Hk8WoMr3xTsr4VZHbWtWuH)
[2019-06-19 19:52:27.499539] [0x00007f8fdd88b7c0] [debug] Wallet with negative balance (-0.0108574) detected: EFC05C1ECB0A0F74E5CE4601C5833F0D105B612B7C2E63B18423663832999D7C (H8tZhab1BzB5ZqV2xhJoJNU39AjDCCvPLbHGsWpwUZtw)

All addresses are contracts using payable().