CREDITSCOM / node

Credits Node is the main module that provide an opportunity to run a node and participate in CREDITS blockchain network.
https://developers.credits.com/
GNU Affero General Public License v3.0
151 stars 16 forks source link

[BUG][CRITICAL] delay network with node clock time #44

Open micmac0 opened 5 years ago

micmac0 commented 5 years ago

I was remembering that some block timestamp were written with one of the TN time. First I was not thinking it was a big issue, but if block timestamp is used as a proof for a transaction (for exemple patent) i was wondering what happen if I change date.

First I disabled NTP client, and change date D - 10days. It looks like I was not able to be TRUSTED anymore (I will need a try later) Then I enabled NTP client and got exact date on my system and node become TRUSTED again. Until now it looks good.

Afterwards I disabled again NTP client on system and set clock to tomorrow. Just after I checked monitor on Testnet, and chain is stuck. I can t be sure 100% this is due to my manipulation but probabilty looks high. See picture below : (now 18 minutes by the time I write this issue)

image

Please find my node logs here too : may be start read them from this point : (block 1897259) [2019-07-18 21:23:00.336920] [0x00007f4c352be700] [debug] NODE> Hash sent, round: 1897258.0, message: 2000000000000000527EE4A591EF6AEF38EA885B0ABF696C9E258F53E1734E9BB4D6D047F3C51FAF060670A789066C010000 [2019-07-18 21:23:01.116123] [0x00007f4c35abf700] [warning] strange: too many tasks 348 [2019-07-19 00:00:00.063620] [0x00007f4c35abf700] [warning] strange: too many tasks 217 [2019-07-19 00:00:00.065808] [0x00007f4c35abf700] [warning] strange: too many tasks 251 [2019-07-19 00:00:00.187054] [0x00007f4c352be700] [debug] NODE> next round table received, round: 1897259

later on I enabled again NTP

log_141.txt.gz

I was able to redo it at block #1898883 just going from now() to tomorrow 0h or block (#1901323) D+2 log_142.txt.gz

cdmitry77 commented 5 years ago

Hi! Did you run only one node with the invalid time? Were there any other nodes with invalid time working together? Thanks in advance.

botstorm commented 5 years ago

Скриншот 19-07-2019 101814