search

CREEATION / gulp-jade-globbing

Globbing Jade includes & extends the easy way.
https://www.npmjs.com/package/gulp-jade-globbing
MIT License
11 stars 1 forks source link

Parsing extended files to avoid forget some "hidden" globbing #4

Closed ivanbanov closed 9 years ago

ivanbanov commented 9 years ago

With this commit the issue #3 should be fixed

peterbraden commented 9 years ago

This introduces a breaking change in files that extend without a .jade suffix.

Jade allows extend ./foo/bar omitting the .jade ending - see: https://github.com/jadejs/jade/blob/master/lib/index.js#L71

However with this fs.readFileSync assumes that the extend glob has the suffix. Leading to:

ENOENT, no such file or directory './foo/bar'

Because this is a bugfix release, it transparently updated on our CI server, causing our builds to start failing. Rather than a 'bugfix' release, this should probably be a minor release as it is not technically backwards compatible.

Thanks!

CREEATION commented 9 years ago

Just reverted this pull request. I don't know much about versioning, sorry about that... Does it work now or do I need to change something?

peterbraden commented 9 years ago

No problem, I already fixed it in our system :)

Basically, for any API change you need to bump a major or minor number, rather than a bugfix number, as these update transparently.

CREEATION commented 9 years ago

Alright, thank you =)