CRG-CNAG / CalliNGS-NF

GATK RNA-Seq Variant Calling in Nextflow
Mozilla Public License 2.0
131 stars 54 forks source link

Use option instead of genome regeneration in STAR for 2-pass mapping #27

Closed kojix2 closed 3 years ago

kojix2 commented 3 years ago

Hi CalliNGS-NF developers and @lucacozzuto .

This pull request is to try to fix #26. If you change the method to the one recommended in the Star manual, you will be able to reduce the execution time. The output files were compared before and after the change.

file Is it the same before and after the change?
final.vcf identical except for the timestamp.
commonSNPs.diff.sites_in_files identical.
known_snps.vcf.gz identical except for the timestamp.
ASE.tsv identical.
AF.histogram.pdf has a binary difference, but the output looks identical.
known_snps.vcf.gz.tbi has a binary difference.

I am not sure if such a simple change of options is enough. This is just a suggestion. I would appreciate it if you could review it.

Thank you.

kojix2 commented 3 years ago

Thanks!