search

CRI-iAtlas / shiny-iatlas

An interactive web portal for exploring immuno-oncology data. This repo now superseded by iatlas-app
https://www.cri-iatlas.org
Apache License 2.0
47 stars 12 forks source link

Possible failure of Clinical Outcome module on Custom Sample Group #138

Closed vthorsson closed 4 years ago

vthorsson commented 5 years ago

Sample Group Survival report error on an example file

https://raw.githubusercontent.com/CRI-iAtlas/shiny-iatlas/develop/data/example_user_group2.csv

selecting COAD

Loading of file, and other modules appear normal.

vthorsson commented 4 years ago

@Gibbsdavidl can you help evaluate the status of this and tag/close/assign accordingly. Thanks

Gibbsdavidl commented 4 years ago

Oh, fixed it! The fix and some improvements are in the surv_group_fix branch.

Gibbsdavidl commented 4 years ago

Would be good if someone tested it.

andrewelamb commented 4 years ago

@Gibbsdavidl This fix is conflicting with the current develop branch. Could you merge develop into your surv_group_fix branch and resolve that?

vthorsson commented 4 years ago

Did the test on surv_group_fix branch and it looks good to me