CRIPAC-DIG / SR-GNN

[AAAI 2019] Source code and datasets for "Session-based Recommendation with Graph Neural Networks"
823 stars 270 forks source link

Softmax function not being applied? : PyTorch Code #16

Closed rithinch closed 5 years ago

rithinch commented 5 years ago

In the paper it is mentioned that the softmax function is being applied to the outputs after computing scores for each candidate item (equation 9), however, the PyTroch Implemention (compute_scores method) doesn't seem to be doing that. Is there a reason why it isn't used?

I have tested the model with the softmax function (default hyperparameters), and the evaulation metrics peformance has drastically decreased. I suspect if it has anything to do with the low output values after softmax. Any thoughts on this?

RuihongQiu commented 5 years ago

nn.CrossEntropyLoss()

rithinch commented 5 years ago

Thanks for clarifying. @RuihongQiu