Open tylerstright opened 3 years ago
Two commits to address this:
https://github.com/CRITFC/tribalCDMS-fe/commit/1713a33fccb8e5755cb0ee5f4b5df340d66c6f37 Moved html elements for messages inside the form div Replaced html SaveMessage reference with SuccessMessage Added event lister clear messages on next click
https://github.com/CRITFC/tribalCDMS-fe/commit/e9424790b172ce6a92afb69e0f2b0eebbbcbc70f Rewired the openModal functions to call setMessage functions.
Please pull and test
Hey Joe –
Probably not going to get to test this today, but hopefully Monday.
Cheers Tyler
From: Joe Nowinski @. Sent: Wednesday, October 6, 2021 6:05 PM To: CRITFC/Helpdesk @.> Cc: Tyler Stright @.>; Author @.> Subject: Re: [CRITFC/Helpdesk] Success/Failed response issues (#57)
Two commits to address this:
@.***https://github.com/CRITFC/tribalCDMS-fe/commit/1713a33fccb8e5755cb0ee5f4b5df340d66c6f37 Moved html elements for messages inside the form div Replaced html SaveMessage reference with SuccessMessage Added event lister clear messages on next click
@.***https://github.com/CRITFC/tribalCDMS-fe/commit/e9424790b172ce6a92afb69e0f2b0eebbbcbc70f Rewired the openModal functions to call setMessage functions.
Please pull and test
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CRITFC/Helpdesk/issues/57#issuecomment-937335427, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKBRTCIWF52RAZ32BFZ44K3UFTPZDANCNFSM5FPZ3VAQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
I discovered this while testing groups in the organization permissions. When you go in to create or edit a group and click cancel to exit the modal window, "Failed!" is displayed in the bottom in a green box. It should both not show a response, and not be in green if the message itself is "Failed!".
Inspecting the html shows two elements
and i chased the code to admin-organizations.js and admin-organizations.html
EDIT: I made some edits to see if I could figure this out so not all of the code may be as it was originally.