CROCODILE-CESM / regional-mom6

Automatic generation of regional configurations of the Modular Ocean Model 6 (MOM6) in Python
https://regional-mom6.readthedocs.io/en/latest
MIT License
0 stars 0 forks source link

Ensure proper handling of mimum depth and ocean mask #10

Open ashjbarnes opened 6 days ago

ashjbarnes commented 6 days ago

As pointed out by @gustavo-marques and then by @fredc , there are ways that you can mess up the choice of minimum depth.

Namely, we need to ensure that the choice of minimum depth doesn't end up causing cells that are only 1 level deep. This used to be the case (and still is in the COSIMA main branch), but since then I switched to using minimum depth instead of minimum layers to simplify the generation of the ESMF Mesh mask.

@fredc suggested that instead of masking out areas that are shallower than minimum depth, we should simply deepen them to match the minimum depth so that the land / ocean mask remains more accurate