Closed manishvenu closed 1 month ago
Hey @ashjbarnes,
Let me know if you have any opinions on what should be added or taken out from here!
I don't want to try to remove the OBC stuff from the default MOM_input files b/c not sure if I 'll miss a place they are stored based on if installed as a package or cloned, so I'll manually delete those fields in setup_run_directory.
I don't want to try to remove the OBC stuff from the default MOM_input files b/c not sure if I 'll miss a place they are stored based on if installed as a package or cloned, so I'll manually delete those fields in setup_run_directory.
Should be fine to delete them - the only difference with installed vs not installed is to do with the directory structure of the package. Either way, it'll always be in the premade_run_directories
folder. So you can delete if you'd prefer! That's probably cleaner than doing programatically each time
I don't want to try to remove the OBC stuff from the default MOM_input files b/c not sure if I 'll miss a place they are stored based on if installed as a package or cloned, so I'll manually delete those fields in setup_run_directory.
Should be fine to delete them - the only difference with installed vs not installed is to do with the directory structure of the package. Either way, it'll always be in the
premade_run_directories
folder. So you can delete if you'd prefer! That's probably cleaner than doing programatically each time
Sounds good, I'll take it out of the premade_run_directories folder, but keep in the deletion to explicitly state it in setup_run_directories.
Issue #8 will be tested again tomorrow and closed with the new demo. This PR does address this. Issue #9 will be addressed in start_angled_boundaries, which will be merged when Issue #8 is finished.
This (originally draft) PR is a conglomeration of work by @ashjbarnes and me adding tidal boundary conditions, certain MOM file functions, and other quality of life improvements to RM6. Here is a categorization of the changes and TO-DOs:
Add tides from GFDL NWA25 to RMOM6 in 5 functions:
Change function names to verb-starts & more descriptive names
Make the changes to MOM files caused by RMOM6 more understandable (addresses #8)
Extraneous small changes