Add angled grids to RMOM6

CROCODILE-CESM / regional-mom6

Automatic generation of regional configurations of the Modular Ocean Model 6 (MOM6) in Python

https://regional-mom6.readthedocs.io/en/latest

MIT License

0 stars 2 forks source link

Add angled grids to RMOM6 #13

Closed manishvenu closed 1 month ago

manishvenu commented 1 month ago

This is a draft PR to add angled grids to RMOM6 read_existing_grids. Some of the tasks to be done:

[X] Replace RMOM6 coords in segment.rectangular_brushcut with GFDL self.coords to reduce replication, as stated in #12
[x] Use segment.coords and new angle variables to store angled grids, like NWA12
[x] Rotate velocities using the segment.coords angle variable
[ ] Others...

manishvenu commented 1 month ago

You can verify the first checkbox by comparing output from CESM runs /glade/u/home/manishrv/manish_scratch_symlink/hawaii_clean_demo and /glade/u/home/manishrv/manish_scratch_symlinl/hawaii_cd_new_coords

ashjbarnes commented 1 month ago

Found an issue with the way I coded up the "get glorys data" function! We need to make sure that when reading a curved hgrid, it uses the max and min extents of the curved side. For example, the Eastern side of NWA curves slightly, and the glorys download is missing the data after the curve as it goes out of range of our download. This is why NWA was failing