Rename and add release action to deploy action

CROSSINGTUD / CryptoAnalysis

CogniCrypt_SAST: CrySL-to-Static Analysis Compiler

Eclipse Public License 2.0

63 stars 39 forks source link

Rename and add release action to deploy action #709

Closed svenfeld closed 2 weeks ago

svenfeld commented 2 weeks ago

This PR adds a release action to the deploy action.

Creates a tag by using the version which is specified in the pom.xml.
Adds jars for CA and CA Android to the release.
Body of release contains the body of merged PRs to previous tag.

svenfeld commented 2 weeks ago

What do you mean by that? Is that not done by merging a PR?

schlichtig commented 2 weeks ago

@swissiety This action only works on the master and we use it once everything we want to release has been merged. I do not see a need the automate merging (all) PRs from develop as this might take away control of what we want to release and what not. What is your take?

swissiety commented 2 weeks ago

Oh I assumed we would take the current develop state (or another branch we select to run the workflow on) to deploy and could automate merging that commit into master as well. Downside: deploying older Versions would be harder or needs to be handled by the workflow as well (don't merge then?)

What do you mean by that? Is that not done by merging a PR?

It is and its currently done manually as Michael said - so my thought was whether this is a necessary step.

schlichtig commented 2 weeks ago

@swissiety I think that could be a cool feature, but I would like to have this in a seperate action.

So, is this good to merge now?