Usage of standardized propagation methods

CRPropa / CRPropa3

CRPropa is a public astrophysical simulation framework for propagating extraterrestrial ultra-high energy particles. https://crpropa.github.io/CRPropa3/

https://crpropa.desy.de

GNU General Public License v3.0

69 stars 68 forks source link

Usage of standardized propagation methods #413

Closed reichherzerp closed 1 year ago

reichherzerp commented 1 year ago

This pull request standardizes the three propagation modules PropagationCK, PropagationBP, and SimplePropagation. Main changes:

use the adaptive step size method for step increasing introduced for BP also for CK
restructuring of CK process function to match that of BP
increase performance for fixed step size in CK
added 5 new CK tests

lukasmerten commented 1 year ago

Only a couple of small comments. The rest looks good to me. Failing tests are not related to newly introduced code.

lukasmerten commented 1 year ago

@reichherzerp Can't we just go back to use clip instead of the max call? Apart from that @rafaelab and my concern with that, I do not see any problems to merge your PR.

reichherzerp commented 1 year ago

As proposed by @lukasmerten and @rafaelab, I switched back to the clip function (also for SimplePropagation) to be safe for possible future modules that may also increase the step sizes.