CRPropa / CRPropa3

CRPropa is a public astrophysical simulation framework for propagating extraterrestrial ultra-high energy particles. https://crpropa.github.io/CRPropa3/
https://crpropa.desy.de
GNU General Public License v3.0
69 stars 68 forks source link

Photon field bug #416

Closed JulienDoerner closed 1 year ago

JulienDoerner commented 1 year ago

This PR fixes #414.

Currently the photon density is set to 0 in tabular photon fields for all redshift $z < 0$. With this change the density $n(\epsilon, z=0)$ will be used instead. This is of course only an approximation for small future redshifts. Therefore a KISS warning will be given if $z<-1$ is reached.

I also updated the example notebook for the Sim4D in the folder "doc/pages/example_notebooks/Sim4D". This will for the moment not be shown on the documentation website. I would wait for the upcomming revision of the documentation to build it.

lukasmerten commented 1 year ago

Ok from my side know. However, it would be good if someone who was not involved in the bug fix discussion in Bochum gives the final approval.