Fix Acceleration module

CRPropa / CRPropa3

CRPropa is a public astrophysical simulation framework for propagating extraterrestrial ultra-high energy particles. https://crpropa.github.io/CRPropa3/

https://crpropa.desy.de

GNU General Public License v3.0

69 stars 68 forks source link

Fix Acceleration module #419

Closed lukasmerten closed 1 year ago

lukasmerten commented 1 year ago

The signature of ParticleSplitting's constructor definition differe in the .h and the .cpp files. This is problematic when the constructor is used with positional arguments.

This PR fixes it.

Furthermore:

The Example notebook was updated to include a full example including the particle splitting.
The weighting column in the HDFOutput was set from "weight" to "W". This synchronizes the column naming with the TextOutput.

lukasmerten commented 1 year ago

I updated the notebook with a clean run and addressed most of @JulienDoerner comments.

lukasmerten commented 1 year ago

Anything else that needs to be done?