search

CRPropa / CRPropa3

CRPropa is a public astrophysical simulation framework for propagating extraterrestrial ultra-high energy particles. https://crpropa.github.io/CRPropa3/
https://crpropa.desy.de
GNU General Public License v3.0
65 stars 66 forks source link

updated doc for new Python interface via cmake #471

Closed rafaelab closed 4 months ago

rafaelab commented 4 months ago

Minor changes to the documentation to reflect the recent updates.

JulienDoerner commented 4 months ago

Hey @rafaelab, this PR looks good for me. I would have only one minor question. We state "testet for > Python 3.0 and > SWIG 4.0.2", but SWIG itself requires at least Python 3.2. So my question is, which version of Python did we realy tested? The oldest version I ever used was 3.7.

rafaelab commented 4 months ago

Hey @rafaelab, this PR looks good for me. I would have only one minor question. We state "testet for > Python 3.0 and > SWIG 4.0.2", but SWIG itself requires at least Python 3.2. So my question is, which version of Python did we realy tested? The oldest version I ever used was 3.7.

Good point, @JulienDoerner. I said 3.0 just because we don't support Python 2 anymore. I didn't actually test versions prior to 3.7. What is your suggestion? Should we say 3.2, or 3.7?

lukasmerten commented 4 months ago

@rafaelab: Just put whatever is the oldest python version that is used in one of the actions. I guess that is python 3.8 in the ubuntu-20 runner.