search

CRPropa / CRPropa3

CRPropa is a public astrophysical simulation framework for propagating extraterrestrial ultra-high energy particles. https://crpropa.github.io/CRPropa3/
https://crpropa.desy.de
GNU General Public License v3.0
72 stars 69 forks source link

Uf23 #490

Closed MichaelUnger closed 5 months ago

MichaelUnger commented 6 months ago

added new models of the coherent magnetic field from 2311.12120

lukasmerten commented 6 months ago

Hi @MichaelUnger Thanks for providing your new magnetic field model. I will take a look at the code later this week and get back to you.

MichaelUnger commented 6 months ago

Hi @lukasmerten thanks for looking into this! This week I am at a workshop with @asavelie @avvliet and @rafaelab so ideally it would be good to know if there any issues with the pull request, then I can solve them here with them here in person.

Cheers, Michael

lukasmerten commented 5 months ago

Please add a comment to the CHANGELOG file under new features.

lukasmerten commented 5 months ago

Apart from the small changes I suggested this PR looks good to me.

MichaelUnger commented 5 months ago

Thanks for the review, I changed the fork accordingly.