`mark` command issues

[OrangeJuice7]

I didn't have time to check the mark command thoroughly, but here are the issues I have found so far:

• The user guide specifies that all parameters are optional, but the command is not successful with no arguments.
• mark show and mark find are successful, adding people with show and find in their names respectively to default. I don't think this is intended behaviour.
• The mark find sub-command ignores the KEYWORD parameter.
• The app specifies that "Mark names must be alphanumeric and do not contain spaces." However, ^& is a valid name.
• mark m/ find t/owesMoney does not do anything, not even update the display box.

[alyip98]

Hi, thanks for reviewing our app. Could you elaborate on the following points with the expected vs actual behaviour and steps to reproduce?

• mark show and mark find are successful, adding people with show and find in their names respectively to default. I don't think this is intended behaviour.
• The mark find sub-command ignores the KEYWORD parameter.

[OrangeJuice7]

Could you elaborate on the following points with the expected vs actual behaviour and steps to reproduce?

• mark show and mark find are successful, adding people with show and find in their names respectively to default. I don't think this is intended behaviour.

Steps to reproduce:

• Enter add n/find p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney in the command box.
• Enter mark find in the command box.
• The display box shows the message Successfully added 1 people to default (the person whose name is "find"). I expected it to be an invalid command, giving the same output as just typing find in the command box would.

Similar output is given for the mark show command.

• The mark find sub-command ignores the KEYWORD parameter.

Sorry about this. I've tested it again, and the command treats the KEYWORD parameter as additional keywords to find. The command doesn't ignore it. Continuing on from the above steps:

• Enter add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney in the command box.
• Enter mark find John in the command box.
• The display box shows the message Successfully added 2 people to default. I expected that only John Doe would be added, but both John Doe and "find" are added.

Hope this has been helpful to you.

[OrangeJuice7]

As a suggestion, may I recommend that the mark command be split into several commands? e.g. findmark, showmarks... I think this option would make it easier for you to enforce the structure for each sub-function of the mark command.