CS2103-AY1819S1-W13-3 / main

ConTAct - A CS2103 project aimed at making a teaching assistant's job easier
https://cs2103-ay1819s1-w13-3.github.io/main/
MIT License
2 stars 5 forks source link

Refactor the Person class and relevant fields #103

Closed andrewtanJS closed 5 years ago

andrewtanJS commented 5 years ago

The main changes are as follows: Person -> Student Phone -> StudentNumber Address -> Faculty The other many changes follow from these.

77

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 233


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/commons/events/model/CalendarChangedEvent.java 0 1 0.0%
src/main/java/seedu/address/commons/events/ui/StudentPanelSelectionChangedEvent.java 4 5 80.0%
src/main/java/seedu/address/logic/commands/mark/MarkShowCommand.java 0 1 0.0%
src/main/java/seedu/address/logic/parser/MarkCommandParser.java 0 1 0.0%
src/main/java/seedu/address/model/AddressBook.java 12 13 92.31%
src/main/java/seedu/address/model/student/Faculty.java 9 10 90.0%
src/main/java/seedu/address/model/student/IsTaggedPredicate.java 0 1 0.0%
src/main/java/seedu/address/model/student/Student.java 53 54 98.15%
src/main/java/seedu/address/model/student/StudentNumber.java 9 10 90.0%
src/main/java/seedu/address/ui/MainWindow.java 2 3 66.67%
<!-- Total: 336 370 90.81% -->
Totals Coverage Status
Change from base Build 225: 0.01%
Covered Lines: 1860
Relevant Lines: 2398

💛 - Coveralls
andrewtanJS commented 5 years ago

@yogtew where sepcifically so i may change them?

yogtew commented 5 years ago

@yogtew where sepcifically so i may change them?

Okay I will comment in the files where it needs to be changed.

andrewtanJS commented 5 years ago

The student number has been modified to accept only alphanumeric values, and the refactoring has been done for the remainder of the tests.