coveralls
commented
5 years ago Pull Request Test Coverage Report for Build 249
- 159 of 168 (94.64%) changed or added relevant lines in 18 files are covered.
- 4 unchanged lines in 3 files lost coverage.
- Overall coverage increased (+6.0%) to 83.558%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/main/java/seedu/address/commons/events/ui/EventPanelSelectionChangedEvent.java | 4 | 5 | 80.0% | ||
| src/main/java/seedu/address/storage/XmlAdaptedEvent.java | 6 | 7 | 85.71% | ||
| src/main/java/seedu/address/logic/parser/CancelCommandParser.java | 13 | 15 | 86.67% | ||
| src/main/java/seedu/address/model/event/UniqueEventList.java | 13 | 15 | 86.67% | ||
| src/main/java/seedu/address/model/event/Event.java | 24 | 27 | 88.89% | ||
| <!-- | Total: | 159 | 168 | 94.64% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/main/java/seedu/address/model/event/Description.java | 1 | 80.0% | ||
| src/main/java/seedu/address/storage/XmlAdaptedEvent.java | 1 | 47.27% | ||
| src/main/java/seedu/address/model/ModelManager.java | 2 | 90.0% | ||
| <!-- | Total: | 4 | --> |
| Totals | |
|---|---|
| Change from base Build 234: | 6.0% |
| Covered Lines: | 2104 |
| Relevant Lines: | 2518 |
yogtew
These are primarily quality-of-life changes to the entire Event ecosystem, in the form of a cancel command, undo/redo support for scheduling, model management, and optional descriptions.
The cancel command now takes in a specified event (minus the description) and deletes that event from the calendar accordingly.
The model was modified to be the moderator among the versioned calendar and address book, undoing and redoing them accordingly.
Also, the UniqueEventList was modified to maintain a sorted ObservableList through the methods. This was done as opposed to maintaining a TreeSet due to the constraints of the ObservableList.
Finally, the description was changed to be an optional parameter, with the field being wrapped in an Optional and handled accordingly.
Test writing is currently ongoing.