Feedback on week 10 project progress

CS2103-AY1819S2-T12-3 / main

MediTabs: Medicine Stock Taking Application

https://cs2103-ay1819s2-t12-3.github.io/main/

MIT License

2 stars 4 forks source link

Feedback on week 10 project progress #133

Open nus-se-bot opened 5 years ago

nus-se-bot commented 5 years ago

Subject: feedback on week 10 project progress

See mid-v1.3 progress guide for more details of the activities mentioned below.

Mid-milestone progress reports are FYI only. They are not graded.

Team progress

Recommended progress for v1.3

Milestone v1.3 managed systematically
- [x] A suitable deadline set (:heavy_check_mark: well done!)
- [x] Issues allocated to it e.g., link (:heavy_check_mark: well done!)
[ ] A new jar file has been released on GitHub for v1.3 (:exclamation: try to do by next milestone)

Individual progress of @kevvvinn

Follow up from v1.2

[ ] Merged updates to the Developer Guide (:exclamation: try to do by next milestone)

Recommended progress for v1.3

[ ] Has issues/PRs assigned for the milestone (:exclamation: try to do by next milestone)

Individual progress of @jonathanleewh

Recommended progress for v1.3

[x] Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Individual progress of @melpulomas

Recommended progress for v1.3

[x] Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Individual progress of @flxffy

Recommended progress for v1.3

[x] Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Individual progress of @jtankw3

Recommended progress for v1.3

[x] Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Tutor: @nhs-work

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2019-03-28 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

JonathanLeeWH commented 5 years ago

@cs2103-feedback-bot @ccristina I believe there might a mistake in the bot as we did release a new jar file as shown in the image below:

I think there is a possibility the script check for v1.3 release tag with .jar file but that was not what was stated in the instructions requirement for mid v1.3 as in mid v1.3 it was stated to do a proper release titled v1.2.1 etc as we have done above.

I have attached a screenshot of the Week 10 project tab relevant section which stated to release the .jar file with the tag 1.2.1 etc instead of v1.3. I also believe it might be a mistake for the script to check for v1.3 as we are currently in mid v1.3 and if we tag v1.3 now we have to move the tag again later for the actual v1.3 submission:

Thank you for your help. Appreciate it.

nus-se-bot commented 5 years ago

Hi @JonathanLeeWH ,

Thank you for pointing out the discrepancy. You are right, the check for mid-milestone weeks needs to be updated to adhere to naming formats advised in the website. We shall include the updates in our future runs.

As for your team, since this week was non-graded, it would not affect your scores. For next week, the jar associated to v1.3 release tag will be checked.

Thanks, CS2103-feedback-team