CS2103-AY1819S2-W10-1 / main

📖☕ README integrated bookmark manager and feed reader application
https://cs2103-ay1819s2-w10-1.github.io/main/
MIT License
3 stars 5 forks source link

Update UI to be more user-friendly #160

Closed rlrh closed 5 years ago

rlrh commented 5 years ago

Resolves #161 Resolves #177

Ui

Summary of changes:

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 855


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/GoogleNewsCommandParser.java 0 1 0.0%
src/main/java/seedu/address/ui/MainWindow.java 10 11 90.91%
src/main/java/seedu/address/ui/NavigationBar.java 28 31 90.32%
src/main/java/seedu/address/logic/LogicManager.java 0 21 0.0%
<!-- Total: 41 67 61.19% -->
Totals Coverage Status
Change from base Build 836: -0.6%
Covered Lines: 2176
Relevant Lines: 2578

💛 - Coveralls
epicfailname commented 5 years ago

There is a bug, though I cannot figure out what is causing it. To reproduce:

  1. Click Archives button
  2. Enter list command
  3. Click Archives button

The result display is not updated for step 3

rlrh commented 5 years ago

There is a bug, though I cannot figure out what is causing it. To reproduce:

  1. Click Archives button
  2. Enter list command
  3. Click Archives button

The result display is not updated for step 3

Should be fixed with latest commit

qjqqyy commented 5 years ago

With reference to this thread, an issue in JavaFX's CSS font loader means that our custom font will not get loaded when there is a space character in the application path, like for example

Apr 11, 2019 2:07:01 AM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFO: Could not load @font-face font [file:/C:/Users/Qi%20Ji/IdeaProjects/ab4/out/production/resources/fonts/RobotoSlab-Regular.ttf]

As this only happens in development under specific circumstances I suggest we don't bother working around it.


Note that running the shadowJar (or using the gradle task runShadow) works.

rlrh commented 5 years ago

With reference to this thread, an issue in JavaFX's CSS font loader means that our custom font will not get loaded when there is a space character in the application path, like for example

Apr 11, 2019 2:07:01 AM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFO: Could not load @font-face font [file:/C:/Users/Qi%20Ji/IdeaProjects/ab4/out/production/resources/fonts/RobotoSlab-Regular.ttf]

As this only happens in development under specific circumstances I suggest we don't bother working around it.

Note that running the shadowJar (or using the gradle task runShadow) works.

Thanks for this! Fortunately in this case it still fails gracefully by reverting to a default system font.