Closed rlrh closed 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/main/java/seedu/address/logic/parser/GoogleNewsCommandParser.java | 0 | 1 | 0.0% | ||
src/main/java/seedu/address/ui/MainWindow.java | 10 | 11 | 90.91% | ||
src/main/java/seedu/address/ui/NavigationBar.java | 28 | 31 | 90.32% | ||
src/main/java/seedu/address/logic/LogicManager.java | 0 | 21 | 0.0% | ||
<!-- | Total: | 41 | 67 | 61.19% | --> |
Totals | |
---|---|
Change from base Build 836: | -0.6% |
Covered Lines: | 2176 |
Relevant Lines: | 2578 |
There is a bug, though I cannot figure out what is causing it. To reproduce:
Archives
buttonlist
commandArchives
buttonThe result display is not updated for step 3
There is a bug, though I cannot figure out what is causing it. To reproduce:
- Click
Archives
button- Enter
list
command- Click
Archives
buttonThe result display is not updated for step 3
Should be fixed with latest commit
With reference to this thread, an issue in JavaFX's CSS font loader means that our custom font will not get loaded when there is a space character in the application path, like for example
Apr 11, 2019 2:07:01 AM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFO: Could not load @font-face font [file:/C:/Users/Qi%20Ji/IdeaProjects/ab4/out/production/resources/fonts/RobotoSlab-Regular.ttf]
As this only happens in development under specific circumstances I suggest we don't bother working around it.
Note that running the shadowJar
(or using the gradle task runShadow
) works.
With reference to this thread, an issue in JavaFX's CSS font loader means that our custom font will not get loaded when there is a space character in the application path, like for example
Apr 11, 2019 2:07:01 AM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged INFO: Could not load @font-face font [file:/C:/Users/Qi%20Ji/IdeaProjects/ab4/out/production/resources/fonts/RobotoSlab-Regular.ttf]
As this only happens in development under specific circumstances I suggest we don't bother working around it.
Note that running the
shadowJar
(or using the gradle taskrunShadow
) works.
Thanks for this! Fortunately in this case it still fails gracefully by reverting to a default system font.
Resolves #161 Resolves #177
Summary of changes:
list
archives
googlenews
feeds