CS2103-AY1819S2-W10-1 / main

📖☕ README integrated bookmark manager and feed reader application
https://cs2103-ay1819s2-w10-1.github.io/main/
MIT License
3 stars 5 forks source link

Remove sample data on startup #199

Closed thomastanck closed 5 years ago

thomastanck commented 5 years ago

Resolves #156 by not having any initial data.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 940


Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/MainApp.java 1 54.88%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 929: 0.02%
Covered Lines: 2437
Relevant Lines: 2670

💛 - Coveralls
rlrh commented 5 years ago

Should we have one entry so the UI doesn't look so barren? Since when it is inevitably selected, it gets downloaded anyway.

qjqqyy commented 5 years ago

Should we have one entry so the UI doesn't look so barren? Since when it is inevitably selected, it gets downloaded anyway.

Unfortunately that means we have to ship the jar with the data folder, or hardcode the entry's contents somehow. Or else the user can still start the application for the first time while offline and reproduce #156

qjqqyy commented 5 years ago

An alternative approach would be to start the sample entrybook with our user guide, which is accessible via jar:file:/path/to/README.jar!/docs/HelpWindow.html

rlrh commented 5 years ago

Should we have one entry so the UI doesn't look so barren? Since when it is inevitably selected, it gets downloaded anyway.

Unfortunately that means we have to ship the jar with the data folder, or hardcode the entry's contents somehow. Or else the user can still start the application for the first time while offline and reproduce #156

I see, I think it's better to remove the sample data then.