search

CS2103AUG2017-T12-B3 / main

People.connect
https://cs2103aug2017-t12-b3.github.io/main/
MIT License
1 stars 3 forks source link

Regarding unuse login feature #86

Open eugenepeh opened 6 years ago

eugenepeh commented 6 years ago

@aggarwalRuchir ,

Since it was an originally working feature, you might want to add the Screenshot of the original state, a short write up in developer guide and probably list out what else left to be done for that feature.

Also, you can add that developer guide portion in your portfolio afterward.

aggarwalRuchir commented 6 years ago

@eugenepeh I will finish by today. However, I want to ask whether there will be a penalty for that? Because I did put the code as unused code and put the information about it in the Project Portfolio already but not as a developer guide, rather as a proposed enhancement.

eugenepeh commented 6 years ago

Yes, it is too late to make any changes to submitted work. You can still do the work on a PR and seek our approval before merging it into the master branch.

The rationale is that if you put it as proposed enhancement, the grader may not know that its an implemented working feature, so I would suggest that you put it under developer guide.

eugenepeh commented 6 years ago

Sorry, my original comment forgot to take your original deadline into account. You can hold on for now, while I clarify further for you.

aggarwalRuchir commented 6 years ago

@eugenepeh sure. I can still work on a PR. If its required, I will make it otherwise the current version is fine.

eugenepeh commented 6 years ago

@aggarwalRuchir , I have clarified, you can just send an email to Prof. Damith and Mr. Akshay (The head TA) and explain to them in short details why it is unuse, if you would like to claim it as an feature.

aggarwalRuchir commented 6 years ago

@eugenepeh so I don't need to make a PR and add it to the Developer Guide?

eugenepeh commented 6 years ago

@aggarwalRuchir yup, just briefly explain to them will do. They will take note of it when grading your portion.

aggarwalRuchir commented 6 years ago

@eugenepeh yeah I sent them an email of what I did and what is left. I think that would be good enough