CS2103AUG2017-T14-B1 / main

Address Book sample application (Level 4)
https://nus-cs2103-AY1718S1.github.io/addressbook-level4
MIT License
0 stars 3 forks source link

Acceptance Testing #71

Open ErnestOYH opened 6 years ago

ErnestOYH commented 6 years ago

When there are changes to data, this error as shown in Figure 1 below pops up. Commands affected: "add", "edit", "delete", "custom", "upload", "undo", "redo", "clear"

error when adding contacts

(Figure 1: Error due to changes make in data)

The "delete" command using Full Name does not seem to be working as shown in Figure 2.

deletebyname not working

(Figure 2: Delete by full name not working)

When adding a custom field, the result of it isn't shown in the interface as shown in Figure 3. People may not notice that the command has worked as almost nothing is shown. I have noticed that when the names are long, they go off screen as well. Maybe the size can be adjusted.

nickname field not shown even when added

(Figure 3: Nickname Field not showing after being added)

Perhaps more examples can be shown on how custom field can be used as well? Only by randomly input some letters did I notice that custom field can have something other than Nickname as shown in Figure 4.

more examples for custom field

(Figure 4: Random Inputs for Custom field)

"upload" does not seem to work correctly. A new window showing my upload pops up instead of being shown along side the contact as shown in Figure 5.

photo not uploaded to program properly

(Figure 5: Photo not uploaded "properly")

I have noticed that for the new commands, the commands cannot be entered if they are wrong as shown in Figure 6 (I can't fully show it though). I am not sure if it is intentional. Perhaps wrong command input can throw an error message teaching the user how to use the command instead. For example when "custom" is entered, an error message pops up saying it is the wrong input and have an example on how to use custom instead.

command cannot be entered

(Figure 6: Command cannot be entered)

For the updatePhone command, the additional phone numbers added are not shown along with the primary number as shown in Figure 7 below. Only by using "updatePhone 1 showAllPhones" can a user see what other contacts they have added.

other phone numbers not shown

(Figure 7: Additional numbers are not shown)

Just a note on User Guide, the command summary is not updated with the new commands.

ErnestOYH commented 6 years ago

I've seen this advice from another person lawwman for the first issue. "Might be because the jar file is saved in downloads. You might want to update this in your user guide. I think a solution would be to save the jar file in a folder without another jar file." Maybe this can be included as well.

LuLechuan commented 6 years ago

Thanks for the advice, we will fix them accordingly. :)