code quality comments for wenzongteo

[okkhoy]

• header comment can be more precise and concise

• errr... why empty else?

• better to have these kinda things read off a config file than hard coding

• these many levels of nesting is usually an indicator of bad SLAP. try to improve SLAP here.

@wenzongteo FYA

[wenzongteo]

@okkhoy oops i was having the idea that i should throw an assertion error in an empty else as it means it should not enter that else statement. Will remove that empty else statement.

I have a question with regards to catching of exceptions? should i also include an catch all exceptions (catch Exception e) at the end of the each try statement to prevent any possible errors that i did not expect from occurring?

[okkhoy]

WRT exceptions: as long as you know or can think of what you can do for an un-planned exception, you can catch Exception e. The other way to think is let that un-planned exception propagate higher up in the code to some place where it can be handled