Open sooyj opened 7 years ago
Note: Based on the "collate/" in the master branch on retrieved on Sunday.
main:
let A0147996E know that his/her author tag is not correctly written as his/her code still show up in your collated code, e.g. in ModelManager.java.
SLAP is generally ok. Taskdate(String date) can be better written.
Coding standard, spacing, variable naming is ok.
Comment is well written. Slight consistency issue, e.g. the word "guarantee" is sometimes used, but not consistently.
Use of assertion / logging / exception
test:
The naming for the tests does not follow the suggested three-parts naming scheme.
There are some duplicated code. Consider using additional methods or setup() / teardown().
Note: Based on the "collate/" in the master branch on retrieved on Sunday.
main:
let A0147996E know that his/her author tag is not correctly written as his/her code still show up in your collated code, e.g. in ModelManager.java.
SLAP is generally ok. Taskdate(String date) can be better written.
Coding standard, spacing, variable naming is ok.
Comment is well written. Slight consistency issue, e.g. the word "guarantee" is sometimes used, but not consistently.
Use of assertion / logging / exception
test:
The naming for the tests does not follow the suggested three-parts naming scheme.
There are some duplicated code. Consider using additional methods or setup() / teardown().