CS2103JAN2018-W14-B4 / main

Address Book sample application (Level 4)

https://nus-cs2103-ay1718s2.github.io/addressbook-level4/

MIT License

1 stars 4 forks source link

viewDate bug #159

Open nus-se-pr-bot opened 6 years ago

nus-se-pr-bot commented 6 years ago

used buttons to navigate through the calendar from 20th april back to 6th april

typed viewDate 2018-04-20

said calendar was already on that date.

_{[original: nus-cs2103-AY1718S2/pe-round1#848]}

Issue created by: @JoonKai1995

WJY-norainu commented 6 years ago

87

muruges95 commented 6 years ago

can create a static method inside calendarpanel to get the current date from the calendarview Then just need to override the default methods that occur when clicking the right and left buttons to update the static current date field.

muruges95 commented 6 years ago

Either that or we remove the buttons that appear.

WJY-norainu commented 6 years ago

I think we included this in our UG (by warning users not to click inside the calendar at all, except for the scrolling bar) So I didn't have plans to fix this in v1.5 and pushed it to v2.0 This bug is actually not caused by buttons, is the one clicking the date in month calendar view page. Originally I tried to resolve by disabling the mouse click into calendar but didn't manage to make big progress

WJY-norainu commented 6 years ago

As for creation of static variables, I was trying to preserve the interaction relationship between different componenets so not sure if this actually violates the current relationship between UI and Model components. Think following the original product, UI cannot feedback to Model?

muruges95 commented 6 years ago

Alright then we will just try to disable mouse clicks in the calendar.