search

CS2113-AY1819S1-W13-1 / main

FreeTime
MIT License
0 stars 3 forks source link

Edit command causes issues with login #171

Closed cjinting-nus closed 5 years ago

cjinting-nus commented 5 years ago

Modifying the name (also means changing the username in this case) would cause the login to stop working

I think this is due to the method logic.matchUserToPerson()

Proposed solution would be to either:

  1. Modify such that changing the name modifies the username as well (in users.json)
  2. Disallow the modification of the username/name

image

nianfei97 commented 5 years ago

2 is probably the easiest way, especially at this juncture

cjinting-nus commented 5 years ago

I think it will affect how friends work as well since they are stored on Person after calling friend or unfriend

bennchong commented 5 years ago

I think it will affect how friends work as well since they are stored on Person after calling friend or unfriend

Yep it will. I will go with 2 as its pretty common that you can't change your username