search

CS2212-2012-G2 / SurvivorPool

CS2212 Project
Other
1 stars 0 forks source link

Possible Solution to the "Add" confusion #51

Closed Nava2 closed 12 years ago

Nava2 commented 12 years ago

So, @slyos and I were shooting ideas around and thought of the following:

  1. Change the "Add New" button to be "New"
  2. Functionality of all buttons remains consistant with current ones
  3. Change the "Save" button to say "Add" if the contestant is new, "Save" otherwise
  4. When clicking "Add" when a field has been modified, show a save dialog (checkbox to ignore in future) saying that the player will be saved
  5. Have the status panel (@Demelode) stating "Add New Contestant" or "Modify Existing" as per the state currently in

How does this sound?

JustinMcDonald commented 12 years ago

this works

slyos commented 12 years ago

Do you mind explaining point 4 more? I don't see why there needs to be a dialog to confirm something that can be reverted.

Nava2 commented 12 years ago

just to tell them they are saving by clicking add new? :s

Someone at some point mentioned this. Its much more applicable to players. Perhaps implement it there and not on contestants?

slyos commented 12 years ago

Doesn't add mean that you are adding? It's just weird we will take the focus away for something that can be quickly reverted by hitting the delete button.

Nava2 commented 12 years ago

Or just editing.. I agree with the dialog for the Contestant.

Also, as an aside, should users be able to change their IDs before the season starts?

Nava2 commented 12 years ago

So this appears to be in conclusion our best option.

What will be implemented:

  1. Change the "Add New" button to be "New"
  2. Functionality of all buttons remains consistent with current ones
  3. Change the "Save" button to say "Add" if the contestant is new, "Save" otherwise
  4. When clicking "Add" when a field has been modified, show a save dialog (checkbox to ignore in future) saying that the player will be saved (does not apply to contestants, should players allow all to be mutable, then we remove this)
  5. Have the status panel (@Demelode) stating "Add New Contestant" or "Modify Existing" as per the state currently in
Nava2 commented 12 years ago

I could have sworn I commented on this in a commit.. But I implemented the plan I had, except that status panel addition @Demelode.

JonDemelo commented 12 years ago

So is this dealt with? I'm pretty happy where everything is standing right now.

Nava2 commented 12 years ago

can you add the label into the status panel?

Nava2 commented 12 years ago

Closed...