search

CS3219-AY2324S1 / ay2324s1-course-assessment-g11

ay2324s1-course-assessment-g11 created by GitHub Classroom
MIT License
3 stars 2 forks source link

Matching UI #82

Closed ckcherry23 closed 1 year ago

ckcherry23 commented 1 year ago

Fixes #45

chunweii commented 1 year ago

Since the match backend is completed, should we integrate the match frontend in this PR too?

ong6 commented 1 year ago

Since the match backend is completed, should we integrate the match frontend in this PR too?

we can do it in a new PR

ckcherry23 commented 1 year ago

LGTM, after the match is found we redirect them to the Room right?

Right now they should accept the match and then they are redirected

If this is not possible with the backend implementation, I can redirect automatically

ong6 commented 1 year ago

LGTM, after the match is found we redirect them to the Room right?

Right now they should accept the match and then they are redirected

If this is not possible with the backend implementation, I can redirect automatically

It should be fine - matching service should give a room ID we can redirect to