Closed jenlmoore closed 1 year ago
Merging #102 (7fd2181) into main (e9c824c) will increase coverage by
0.40%
. The diff coverage is91.38%
.
@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 88.64% 89.04% +0.40%
==========================================
Files 62 59 -3
Lines 2403 1998 -405
==========================================
- Hits 2130 1779 -351
+ Misses 273 219 -54
Impacted Files | Coverage Δ | |
---|---|---|
UtahModules/Sources/UtahProfile/LogOutButton.swift | 45.46% <ø> (-2.37%) |
:arrow_down: |
...ahModules/Sources/UtahProfile/MenuButtonView.swift | 75.00% <ø> (+3.00%) |
:arrow_up: |
...tahSchedule/Edmonton/EdmontonViewCoordinator.swift | 0.00% <ø> (ø) |
|
...ahModules/Sources/UtahOnboardingFlow/Welcome.swift | 81.25% <57.15%> (-7.93%) |
:arrow_down: |
...EdmontonVEINES/EdmontonVEINESViewCoordinator.swift | 57.15% <57.15%> (ø) |
|
...hModules/Sources/UtahOnboardingFlow/UtahLogo.swift | 87.50% <87.50%> (ø) |
|
...ces/UtahSharedContext/SourceFirestoreManager.swift | 91.67% <97.92%> (+12.50%) |
:arrow_up: |
...UtahOnboardingFlow/AccountSetup/AccountSetup.swift | 95.54% <100.00%> (+2.68%) |
:arrow_up: |
...Sources/UtahOnboardingFlow/ConditionQuestion.swift | 92.46% <100.00%> (+0.79%) |
:arrow_up: |
...ahModules/Sources/UtahOnboardingFlow/Consent.swift | 91.18% <100.00%> (+2.72%) |
:arrow_up: |
... and 12 more |
... and 6 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cfcc7d1...7fd2181. Read the comment docs.
Combine Edmonton+Veines with scheduler
:recycle: Current situation & Problem
Mentors wanted the 2 surveys to be seamless and look as if it is one survey. They want this to be in the scheduler.
:bulb: Proposed solution
Make one large survey with both Edmonton and Veines. In the controller parse out the different surveys and upload the fhir separately to Firebase and calculate scores separately as well + push to firebase.
:gear: Release Notes
:heavy_plus_sign: Additional Information
Will do the Edmonton+WIQ next
Related PRs
Testing
Reviewer Nudging
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: