codecov[bot]
commented
1 year ago Codecov Report
Merging #122 (fbfa539) into main (7c50282) will increase coverage by
0.13%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 83.60% 83.72% +0.13%
==========================================
Files 59 59
Lines 2024 2027 +3
==========================================
+ Hits 1692 1697 +5
+ Misses 332 330 -2 | Impacted Files | Coverage Δ | |
|---|---|---|
| UtahModules/Sources/UtahTrends/DataCard.swift | 94.53% <100.00%> (+0.08%) |
:arrow_up: |
| UtahModules/Sources/UtahTrends/Trends.swift | 95.84% <100.00%> (+4.53%) |
:arrow_up: |
| UtahUITests/TrendsTests.swift | 100.00% <100.00%> (ø) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7c50282...fbfa539. Read the comment docs.
jenlmoore
Trend Page UI Updates
:recycle: Current situation & Problem
There were a few issues with the Trends Page UI: 1) Placeholder text for the WIQ survey 2) No indication that the user could tap on the data cards to see a chart 3) Data cards would load in varying orders 4) Data card labels inaccurate
:bulb: Proposed solution
1) Removed WIQ Survey placehold text so now nothing renders 2) Added a small arrow icon to the Data Card to indicate to tap to see the charts 3) Render survey data cards in alphabetical order 4) Updated data card labels
:gear: Release Notes
:heavy_plus_sign: Additional Information
Related PRs
Testing
Also updated Trends UITests to reflect changes.
Reviewer Nudging
Where should the reviewer start? Where is a good entry point?
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: