CS342 / 2023-Utah

The CS342 2023 U-STEP Project
MIT License
0 stars 3 forks source link

Building off of surveyHistoryFinal #123

Closed ivyalin2015 closed 1 year ago

ivyalin2015 commented 1 year ago

Create Survey History

:recycle: Current situation & Problem

UI not finalized for the questionnaire history section

:bulb: Proposed solution

Fixed background of the surveyhistory page to be consistent with the rest of the app; added score description for the individual questionnaires

:gear: Release Notes

copied the surveyHistoryFinal branch b/c was a detached head - this is the most updated version of that branch!

:heavy_plus_sign: Additional Information

refer to this branch instead of the surveyHistoryFinal and all branches with similar names - they are now outdated

Related PRs

surveyHistoryFinal, etc.

Testing

Are there tests included? If yes, which situations are tested, and which corner cases are missing?

Reviewer Nudging

Simulator Screen Shot - iPhone 14 Pro - 2023-03-15 at 18 00 49 Simulator Screen Shot - iPhone 14 Pro - 2023-03-15 at 18 00 36 Simulator Screen Shot - iPhone 14 Pro - 2023-03-15 at 18 00 59

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

jenlmoore commented 1 year ago

Can you please update the branch with main (switch to the main branch and 'pull' from it, then switch back to yours and update it from main)? Thanks!

Also, if the other PRs you have open are outdated, can you please close them? I don't want to do it incorrectly on accident

jenlmoore commented 1 year ago

You can run 'swiftlint --fix' in your terminal and it can get rid of some of the issues automatically, although there might be more you have to manually fix

codecov[bot] commented 1 year ago

Codecov Report

Merging #123 (a966e57) into main (7c50282) will increase coverage by 0.59%. The diff coverage is 18.85%.

:exclamation: Current head a966e57 differs from pull request most recent head dd293d4. Consider uploading reports for the commit dd293d4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   83.60%   84.19%   +0.59%     
==========================================
  Files          59       59              
  Lines        2024     2036      +12     
==========================================
+ Hits         1692     1714      +22     
+ Misses        332      322      -10     
Impacted Files Coverage Δ
UtahModules/Sources/UtahProfile/DQRowView.swift 0.00% <0.00%> (ø)
...ources/UtahProfile/DetailedQuestionnaireView.swift 0.00% <0.00%> (ø)
...odules/Sources/UtahProfile/SurveyHistoryList.swift 44.45% <50.00%> (ø)
...ules/Sources/UtahProfile/UserInformationView.swift 100.00% <100.00%> (ø)
UtahUITests/ProfileTests.swift 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 124bfe4...dd293d4. Read the comment docs.

ivyalin2015 commented 1 year ago

let me know if everything worked!

jenlmoore commented 1 year ago

UI and code looks awesome!! Great job!!!

jenlmoore commented 1 year ago

Just waiting for tests to finish, then will approve and merge!