CS342 / 2023-Utah

The CS342 2023 U-STEP Project
MIT License
0 stars 3 forks source link

added Veines Survey #124

Closed jennxu23 closed 1 year ago

jennxu23 commented 1 year ago

Added Veines Chart

:recycle: Current situation & Problem

The Veines data card does not have an associated chart.

:bulb: Proposed solution

I made the Edmonton Chart view more generalizable to all surveys, and added a Veines chart.

:gear: Release Notes

:heavy_plus_sign: Additional Information

Provide some additional information if possible

https://user-images.githubusercontent.com/56773304/225526425-e0829d49-19c7-418d-aa96-1ca1d92aa93f.mp4

Related PRs

Testing

Reviewer Nudging

Where should the reviewer start? Where is a good entry point?

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 year ago

Codecov Report

Merging #124 (7f45082) into main (bed51d0) will decrease coverage by 0.24%. The diff coverage is 33.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   84.42%   84.17%   -0.24%     
==========================================
  Files          59       59              
  Lines        2066     2072       +6     
==========================================
  Hits         1744     1744              
- Misses        322      328       +6     
Impacted Files Coverage Δ
UtahModules/Sources/UtahTrends/Trends.swift 85.19% <14.29%> (-10.64%) :arrow_down:
...ahModules/Sources/UtahTrends/SurveyChartView.swift 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bed51d0...7f45082. Read the comment docs.