CS342 / 2023-Utah

The CS342 2023 U-STEP Project
MIT License
0 stars 3 forks source link

Connect data to charts #125

Closed jchen23-stf closed 1 year ago

jchen23-stf commented 1 year ago

Connected Survey Charts to actual data

:recycle: Current situation & Problem

The charts for each of the surveys were displaying dummy data.

:bulb: Proposed solution

We connected the chart view to actual survey data.

:gear: Release Notes

Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes. Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.

:heavy_plus_sign: Additional Information

Provide some additional information if possible

Related PRs

N/A

Testing

N/A

Reviewer Nudging

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

jenlmoore commented 1 year ago

I just want to confirm that with this PR, all surveys will now have corresponding charts appear when the data card is clicked right? There seemed to be no WIQ data card before so want to make sure.

codecov[bot] commented 1 year ago

Codecov Report

Merging #125 (7b306cd) into main (e7f177a) will increase coverage by 12.96%. The diff coverage is n/a.

:exclamation: Current head 7b306cd differs from pull request most recent head 0df7b71. Consider uploading reports for the commit 0df7b71 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #125       +/-   ##
===========================================
+ Coverage   84.17%   97.13%   +12.96%     
===========================================
  Files          59       11       -48     
  Lines        2072      383     -1689     
===========================================
- Hits         1744      372     -1372     
+ Misses        328       11      -317     

see 48 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7f177a...0df7b71. Read the comment docs.