Closed jennxu23 closed 1 year ago
Merging #95 (73df59b) into main (e9c824c) will increase coverage by
1.94%
. The diff coverage is98.32%
.
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 88.64% 90.58% +1.94%
==========================================
Files 62 61 -1
Lines 2403 2429 +26
==========================================
+ Hits 2130 2200 +70
+ Misses 273 229 -44
Impacted Files | Coverage Δ | |
---|---|---|
UtahModules/Sources/UtahProfile/LogOutButton.swift | 45.46% <ø> (-2.37%) |
:arrow_down: |
...ahModules/Sources/UtahProfile/MenuButtonView.swift | 75.00% <ø> (+3.00%) |
:arrow_up: |
...hModules/Sources/UtahOnboardingFlow/UtahLogo.swift | 87.50% <87.50%> (ø) |
|
...ces/UtahSharedContext/SourceFirestoreManager.swift | 91.67% <97.92%> (+12.50%) |
:arrow_up: |
...UtahOnboardingFlow/AccountSetup/AccountSetup.swift | 95.54% <100.00%> (+2.68%) |
:arrow_up: |
...ahModules/Sources/UtahOnboardingFlow/Consent.swift | 91.18% <100.00%> (+2.72%) |
:arrow_up: |
...ahModules/Sources/UtahOnboardingFlow/Welcome.swift | 90.70% <100.00%> (+1.51%) |
:arrow_up: |
UtahModules/Sources/UtahProfile/FormView.swift | 96.56% <100.00%> (ø) |
|
UtahModules/Sources/UtahProfile/HeaderBanner.swift | 100.00% <100.00%> (ø) |
|
UtahModules/Sources/UtahProfile/HelpPageView.swift | 100.00% <100.00%> (ø) |
|
... and 8 more |
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e72fab6...73df59b. Read the comment docs.
Get average weekly step count
:recycle: Current situation & Problem
The current app displays daily step count. We want to get the average weekly step count.
:bulb: Proposed solution
Currently, the app pulls the daily step count from the Health App on the iPhone. In this PR, I modified the Trends page to pull data from firestore directly. This makes it easier to test if the trends page is pulling data accurately, as local health data gets wiped every time we reset the XCode simulator.
I also changed the trend to display the average step count based on the last 7 days.
:gear: Release Notes
Updated Step Count after adding new data point in.
:heavy_plus_sign: Additional Information
There are still some known issues:
[RESOLVED] - The value in the trends page isn't updated automatically. I have to switch between the trends tab and another tab twice before I can see the update. [RESOLVED] - This PR is currently failing the Trends UITest. This is because observations aren't being uploaded for the mock account created in the UITests. However, observations are being uploaded when I manually create an account.--
Related PRs
N/A
Testing
Trends UI Test
Reviewer Nudging
N/A
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: