CS342 / 2024-Prisma

MIT License
2 stars 1 forks source link

Chat interface hosting web components #20

Closed EvelynBunnyDev closed 7 months ago

EvelynBunnyDev commented 7 months ago

Successfully loaded a web placeholder (google) in chat interface

Swift Chat Interface

:recycle: Current situation & Problem

New branch that hosts an interactive React web view within the SwiftUI interface

:gear: Release Notes

Added WebView under Chat as a SwiftUI Wrapper Modified ChatView under Chat to host desired website. Currently I put localhost for Prisma web as a placeholder, which works. if let url = URL(string: "https://www.google.com/") Need additional work on formatting.

  1. Chat interface should not zoom in after typing initial message.
  2. Ensuring consistency across iPads and iPhones.
  3. Next step is implementing user authentication.

:books: Documentation

Please reference in-line documentation.

image

:white_check_mark: Testing

All tests passed. Additional tests to be added for web performance.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

mjoerke commented 7 months ago

Hi @EvelynBunnyDev, thank you for the PR! This is exciting.

If you replace the url with if let url = URL(string: "http://localhost:3000") while locally running the frontend, you should be able to see our chat interface from the app in the simulator.

EvelynBunnyDev commented 7 months ago

Hi @mjoerke (This is Evelyn Song @EvelynBunnyDev, not Evelyn Hur :)) I have replaced the link with localhost and the chat interface was successfully loaded! I am currently troubleshooting formatting errors. I believe this would make a great demo on the midterm presentation.

mjoerke commented 7 months ago

Great! Sorry for mixing up your usernames 🙃

codecov[bot] commented 7 months ago

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f577d2d) 38.31% compared to head (e157b9c) 37.90%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CS342/2024-Prisma/pull/20/graphs/tree.svg?width=650&height=150&src=pr&token=Kl2PgPHuci&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342)](https://app.codecov.io/gh/CS342/2024-Prisma/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) ```diff @@ Coverage Diff @@ ## main #20 +/- ## ========================================== - Coverage 38.31% 37.90% -0.41% ========================================== Files 38 39 +1 Lines 1287 1301 +14 ========================================== Hits 493 493 - Misses 794 808 +14 ``` | [Files](https://app.codecov.io/gh/CS342/2024-Prisma/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) | Coverage Δ | | |---|---|---| | [Prisma/Chat/WebView.swift](https://app.codecov.io/gh/CS342/2024-Prisma/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342#diff-UHJpc21hL0NoYXQvV2ViVmlldy5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [Prisma/Chat/ChatView.swift](https://app.codecov.io/gh/CS342/2024-Prisma/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342#diff-UHJpc21hL0NoYXQvQ2hhdFZpZXcuc3dpZnQ=) | `15.79% <0.00%> (-5.63%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CS342/2024-Prisma/pull/20?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CS342/2024-Prisma/pull/20?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). Last update [f577d2d...e157b9c](https://app.codecov.io/gh/CS342/2024-Prisma/pull/20?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342).
PSchmiedmayer commented 7 months ago

@EvelynBunnyDev Great to see the progress! Feel free to request reviews from your team members, if you have any specific question for me just tag me in a comment 🚀