CS342 / 2024-Prisma

MIT License
2 stars 1 forks source link

Upload HealthKit Device to Firebase #25

Closed mjoerke closed 7 months ago

mjoerke commented 7 months ago

Upload HealthKit Device to Firebase

:recycle: Current situation & Problem

The default SpeziHealthKit implementation does not upload information about which device generated a given HKSample (e.g., iPhone, Apple Watch, Oura, etc.). This has significant implications for downstream featurization, since a user wearing multiple devices might have duplicated data.

:gear: Release Notes

:books: Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide. You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

:white_check_mark: Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested. This section describes important information about the tests and why some elements might not be testable.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 7 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2c4f82f) 35.78% compared to head (12ce18f) 35.65%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CS342/2024-Prisma/pull/25/graphs/tree.svg?width=650&height=150&src=pr&token=Kl2PgPHuci&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342)](https://app.codecov.io/gh/CS342/2024-Prisma/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) ```diff @@ Coverage Diff @@ ## main #25 +/- ## ========================================== - Coverage 35.78% 35.65% -0.12% ========================================== Files 40 40 Lines 1378 1383 +5 ========================================== Hits 493 493 - Misses 885 890 +5 ``` | [Files](https://app.codecov.io/gh/CS342/2024-Prisma/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) | Coverage Δ | | |---|---|---| | [Prisma/Standard/PrismaStandard+HealthKit.swift](https://app.codecov.io/gh/CS342/2024-Prisma/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342#diff-UHJpc21hL1N0YW5kYXJkL1ByaXNtYVN0YW5kYXJkK0hlYWx0aEtpdC5zd2lmdA==) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CS342/2024-Prisma/pull/25?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CS342/2024-Prisma/pull/25?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). Last update [2c4f82f...12ce18f](https://app.codecov.io/gh/CS342/2024-Prisma/pull/25?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342).