CS342 / 2024-Prisma

MIT License
2 stars 1 forks source link

Features/fixadd #44

Closed dhruvna1k closed 6 months ago

dhruvna1k commented 6 months ago

*Fixing add function to make pull request

:recycle: Current situation & Problem

I was using an @Dependency incorrectly and needed to use it within the add function of the Prisma Standard allow the program to run properly and the toggle states can be accessed within the Standard now for omitting data writing to Firestore.

:gear: Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes. Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

:books: Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide. You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

:white_check_mark: Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested. This section describes important information about the tests and why some elements might not be testable.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 35.08%. Comparing base (9c38895) to head (e810961).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44/graphs/tree.svg?width=650&height=150&src=pr&token=Kl2PgPHuci&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342)](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) ```diff @@ Coverage Diff @@ ## main #44 +/- ## ========================================== - Coverage 35.26% 35.08% -0.17% ========================================== Files 44 44 Lines 2031 2007 -24 ========================================== - Hits 716 704 -12 + Misses 1315 1303 -12 ``` | [Files](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) | Coverage Δ | | |---|---|---| | [Prisma/PrivacyControls/PrivacyModule.swift](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342#diff-UHJpc21hL1ByaXZhY3lDb250cm9scy9Qcml2YWN5TW9kdWxlLnN3aWZ0) | `96.30% <100.00%> (+1.79%)` | :arrow_up: | | [Prisma/Standard/PrismaStandard.swift](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342#diff-UHJpc21hL1N0YW5kYXJkL1ByaXNtYVN0YW5kYXJkLnN3aWZ0) | `6.22% <ø> (ø)` | | | [Prisma/Standard/PrismaStandard+HealthKit.swift](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342#diff-UHJpc21hL1N0YW5kYXJkL1ByaXNtYVN0YW5kYXJkK0hlYWx0aEtpdC5zd2lmdA==) | `4.55% <0.00%> (+0.51%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). Last update [9c38895...e810961](https://app.codecov.io/gh/CS342/2024-Prisma/pull/44?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342).