CS342 / 2024-Prisma

MIT License
2 stars 1 forks source link

Account details update: made email & DoB mandatory and updated onboarding texts #5

Closed EvelynBunnyDev closed 9 months ago

EvelynBunnyDev commented 9 months ago

Name of the PR

:recycle: Current situation & Problem

Modifying account detail configurations. Responding to reviewer comment.

:gear: Release Notes

Modified localizable strings (onboarding texts) and made the strings 'automatic' Removed commented code that I'm not implementing.

:books: Documentation

In-line documentation provided.

:white_check_mark: Testing

N/A. All elements should be testable

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 9 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (063b54d) 41.07% compared to head (748f077) 40.90%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CS342/2024-Behavior/pull/5/graphs/tree.svg?width=650&height=150&src=pr&token=Kl2PgPHuci&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342)](https://app.codecov.io/gh/CS342/2024-Behavior/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) ```diff @@ Coverage Diff @@ ## main #5 +/- ## ========================================== - Coverage 41.07% 40.90% -0.17% ========================================== Files 30 30 Lines 957 966 +9 ========================================== + Hits 393 395 +2 - Misses 564 571 +7 ``` | [Files](https://app.codecov.io/gh/CS342/2024-Behavior/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) | Coverage Δ | | |---|---|---| | [Behavior/Account/AccountSheet.swift](https://app.codecov.io/gh/CS342/2024-Behavior/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342#diff-QmVoYXZpb3IvQWNjb3VudC9BY2NvdW50U2hlZXQuc3dpZnQ=) | `0.00% <ø> (ø)` | | | [Behavior/BehaviorDelegate.swift](https://app.codecov.io/gh/CS342/2024-Behavior/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342#diff-QmVoYXZpb3IvQmVoYXZpb3JEZWxlZ2F0ZS5zd2lmdA==) | `95.09% <100.00%> (+0.17%)` | :arrow_up: | | [Behavior/Account/AccountSetupHeader.swift](https://app.codecov.io/gh/CS342/2024-Behavior/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342#diff-QmVoYXZpb3IvQWNjb3VudC9BY2NvdW50U2V0dXBIZWFkZXIuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CS342/2024-Behavior/pull/5?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CS342/2024-Behavior/pull/5?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). Last update [063b54d...748f077](https://app.codecov.io/gh/CS342/2024-Behavior/pull/5?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CS342).
EvelynBunnyDev commented 9 months ago

Looks good 👍

Thank you, Andrea! Could you approve the PR?