search

CS383Team2 / Goofy_Lights_Editor

1 stars 1 forks source link

FrameData DeleteNode RGB Leak #12

Open Cyberzoid1 opened 7 years ago

Cyberzoid1 commented 7 years ago

So I Just remembered this in class.

Before the node is deleted, the method needs to free up the RGB structure. The FrameData contains a pointer to the RGB structure and I think the structure will persist after the node is deleted.

Kevin-Dorscher commented 7 years ago

so I just need to add something like: Delete (Node_To_Delete -> FrameData -> RGB)

before deleting the actual node itself?

I was wondering about this earlier, because I'll have to add the same thing into the DeleteNode_Middle function.

Cyberzoid1 commented 7 years ago

Refer to PR #16

Cyberzoid1 commented 7 years ago

Fixed and PR #16 merged and closed

Cyberzoid1 commented 7 years ago

Merge removed code Also consider #27