CS4850Group5A / VirtuDoc

1 stars 3 forks source link

Fixed dying WebSocket connections #202

Closed ARMmaster17 closed 2 years ago

ARMmaster17 commented 2 years ago

Summary

Closes #201

How to Test

Copy these changes into proxy/nginx.conf and restart the Docker Compose stack (you may need to delete the image from Docker Desktop in order to force a rebuild. If you can't find the image use docker-compose up --build). Verify that WebSocket connections stay open.

Comments

Tagging @PlasAJulian for review since he already has the code in place for testing WebSocket connections.

Note that the WebSocket server on the Spring Boot side must be configured to listen on port 80. The JavaScript-side code should use port 443 (or leave off the port and let the browser figure it out).

github-actions[bot] commented 2 years ago

Unit Test Results

14 files  ±0  14 suites  ±0   16s :stopwatch: -1s 81 tests ±0  81 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit b0664a06. ± Comparison against base commit 2e7e90ba.

:recycle: This comment has been updated with latest results.