search

CSBDeep / CSBDeep_fiji

BSD 2-Clause "Simplified" License
11 stars 4 forks source link

Enh/tiling prediction #8

Closed frauzufall closed 6 years ago

frauzufall commented 6 years ago

It would be great to merge this into master as soon as the tiling is in imglib2. @HedgehogCode Can you have an eye on that? The updated SavedModel import is already implemented in master and I would also enhance the normalization there, just want to make sure we work on the same codebase as soon as possible.

frauzufall commented 6 years ago

Also, should TensorConverterTests.java perhaps move to src/test/java or do you want to remove this later?

frauzufall commented 6 years ago

Looks like we cannot count on the tiling in imglib2 in the very near future, so we have to copy the relevant code to our repo for now.. https://github.com/imglib/imglib2/pull/179

maweigert commented 6 years ago

I think we actually don't need that anyhow as the code we'd need for our purposes will be conceptually easier. I think @HedgehogCode is already working on the simple tiling functionality - you might ask him about that...

frauzufall commented 6 years ago

He did and it works, but it depends on an imglib2 version that is not available via maven yet. That's why I asked for the status in the imglib2 issue. I also talked with @HedgehogCode about that scenario before, it's nothing you have to worry about :)

fjug commented 6 years ago

Tomorrow we can also speak with Tobi… he is the man with the big picture in mind… ;)

On 8. Oct 2017, at 13:07, Deborah Schmidt notifications@github.com wrote:

He did and it works, but it depends on an imglib2 version that is not available via maven yet. That's why I asked for the status in the imglib2 issue. I also talked with @HedgehogCode https://github.com/hedgehogcode about that scenario before, it's nothing you have to worry about :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/frauzufall/CSBDeep/pull/8#issuecomment-334999065, or mute the thread https://github.com/notifications/unsubscribe-auth/ACoGuS1-wlnmMQLRj30R7cSpkOckphPbks5sqKzrgaJpZM4PvAlW.

HedgehogCode commented 6 years ago

I rebased the branch and temporarily added the TiledView, CombinedView and ArragedView, which should go into imglib2 at some point in time.

Should I already merge it? Because it still dependents on changes in imagej-tensorflow where I currently work on the PR: imagej-tensorflow/pull/3.

But the branch is up to date with master and it can be used by importing imagej-tensorflow on the branch kn-hacking into eclipse.